[PATCH 18/60] kvm: Move kvm_vcpu->rcuwait to struct kvm_vcpu_common

From: Jörg Rödel

Date: Mon Jun 08 2026 - 11:06:26 EST


From: Joerg Roedel <joerg.roedel@xxxxxxx>

The rcuwait member is used to block and wake a VCPU thread. Since all
plane VCPUs share a thread, there must only be a single wait object.

Signed-off-by: Joerg Roedel <joerg.roedel@xxxxxxx>
---
arch/loongarch/kvm/timer.c | 2 +-
arch/mips/kvm/mips.c | 4 ++--
include/linux/kvm_host.h | 9 +++++----
virt/kvm/kvm_main.c | 7 ++++---
4 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/arch/loongarch/kvm/timer.c b/arch/loongarch/kvm/timer.c
index 8356fce0043f..9da10aa90558 100644
--- a/arch/loongarch/kvm/timer.c
+++ b/arch/loongarch/kvm/timer.c
@@ -31,7 +31,7 @@ enum hrtimer_restart kvm_swtimer_wakeup(struct hrtimer *timer)

vcpu = container_of(timer, struct kvm_vcpu, arch.swtimer);
kvm_queue_irq(vcpu, INT_TI);
- rcuwait_wake_up(&vcpu->wait);
+ rcuwait_wake_up(kvm_arch_vcpu_get_wait(vcpu));

return HRTIMER_NORESTART;
}
diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c
index f928ba105104..6469ec246dd6 100644
--- a/arch/mips/kvm/mips.c
+++ b/arch/mips/kvm/mips.c
@@ -265,7 +265,7 @@ static enum hrtimer_restart kvm_mips_comparecount_wakeup(struct hrtimer *timer)
kvm_mips_callbacks->queue_timer_int(vcpu);

vcpu->arch.wait = 0;
- rcuwait_wake_up(&vcpu->wait);
+ rcuwait_wake_up(kvm_arch_vcpu_get_wait(vcpu));

return kvm_mips_count_timeout(vcpu);
}
@@ -507,7 +507,7 @@ int kvm_vcpu_ioctl_interrupt(struct kvm_vcpu *vcpu,

dvcpu->arch.wait = 0;

- rcuwait_wake_up(&dvcpu->wait);
+ rcuwait_wake_up(kvm_arch_vcpu_get_wait(dvcpu));

return 0;
}
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index c8085c23e18e..c08ede1cefd2 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -337,6 +337,10 @@ struct kvm_vcpu_common {
#endif
struct mutex mutex;

+#ifndef __KVM_HAVE_ARCH_WQP
+ struct rcuwait wait;
+#endif
+
/* Scheduling state */
#ifdef CONFIG_PREEMPT_NOTIFIERS
struct preempt_notifier preempt_notifier;
@@ -361,9 +365,6 @@ struct kvm_vcpu {

struct kvm_run *run;

-#ifndef __KVM_HAVE_ARCH_WQP
- struct rcuwait wait;
-#endif
struct pid *pid;
rwlock_t pid_lock;
int sigset_active;
@@ -1806,7 +1807,7 @@ static inline struct rcuwait *kvm_arch_vcpu_get_wait(struct kvm_vcpu *vcpu)
#ifdef __KVM_HAVE_ARCH_WQP
return vcpu->arch.waitp;
#else
- return &vcpu->wait;
+ return &vcpu->common->wait;
#endif
}

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 9accca10c249..11e0d4af82df 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -468,6 +468,10 @@ static int kvm_vcpu_init_common(struct kvm_vcpu *vcpu, struct kvm *kvm, unsigned

mutex_init(&common->mutex);

+#ifndef __KVM_HAVE_ARCH_WQP
+ rcuwait_init(&common->wait);
+#endif
+
common->kvm = kvm;
common->current_vcpu = vcpu;

@@ -508,9 +512,6 @@ static void kvm_vcpu_init(struct kvm_vcpu *vcpu, struct kvm *kvm, unsigned id)
vcpu->vcpu_id = id;
vcpu->pid = NULL;
rwlock_init(&vcpu->pid_lock);
-#ifndef __KVM_HAVE_ARCH_WQP
- rcuwait_init(&vcpu->wait);
-#endif
kvm_async_pf_vcpu_init(vcpu);

kvm_vcpu_set_in_spin_loop(vcpu, false);
--
2.53.0