Re: [PATCH] block: fix arg type in `blk_mq_update_nr_hw_queues`
From: Bart Van Assche
Date: Mon Jun 08 2026 - 12:26:39 EST
On 6/8/26 1:39 AM, Andreas Hindborg wrote:
The type of the argument `nr_hw_queues` in the function
`blk_mq_update_nr_hw_queues` is a signed integer. This is wrong,
considering the field `nr_hw_queues` of `struct blk_mq_tag_set` is
unsigned. Thus, change the type of the parameter to unsigned.
Will there ever be storage devices that support more than 2**31 hardware
queues? If not, I think the word "wrong" in the commit message is too
strong.
If this patch does not change the behavior of the code for any practical
use case that would be good to mention.
Thanks,
Bart.