Re: [PATCH v4 03/21] nfs_common: add new NOTIFY4_* flags proposed in RFC8881bis

[Chuck Lever]

Unfortunately, reviewing this series slipped off my radar. I'm just now
getting to it. I'm going to do this in order and some of the earlier
reviews are cosmetic. But there are some significant changes needed
later on, so I expect we'll need to redrive this series and punt it to
v7.3.

One thing you might update before you repost is to remove the "Acked-by:
Chuck Lever" throughout the series.


Nit: the Subject: prefix should be "nfsd:" not "nfs_common:"


On Fri, May 22, 2026, at 8:28 AM, Jeff Layton wrote:
> RFC8881bis adds some new flags to GET_DIR_DELEGATION that we very much
> need to support.

Nit: Let's say: "RFC8881bis adds new flags to GET_DIR_DELEGATION
that later patches consume."

One recent private comment to me was a question about whether we can
trust the stability of the specification, which is still a WG document
and has been for years. This patch's commit message should address
that.


> diff --git a/Documentation/sunrpc/xdr/nfs4_1.x 
> b/Documentation/sunrpc/xdr/nfs4_1.x
> index 632f5b579c39..aa14b590b524 100644
> --- a/Documentation/sunrpc/xdr/nfs4_1.x
> +++ b/Documentation/sunrpc/xdr/nfs4_1.x
> @@ -416,7 +416,21 @@ enum notify_type4 {
>          NOTIFY4_REMOVE_ENTRY = 2,
>          NOTIFY4_ADD_ENTRY = 3,
>          NOTIFY4_RENAME_ENTRY = 4,
> -        NOTIFY4_CHANGE_COOKIE_VERIFIER = 5
> +        NOTIFY4_CHANGE_COOKIE_VERIFIER = 5,
> +        /*
> +         * Added in NFSv4.1 bis document
> +         */

I clarified this comment: "/* Proposed in RFC8881bis */"

I rebuilt the generated source to confirm that it hasn't been altered
by recent changes to xdrgen or this comment change. The only thing
that changed in the output was the header's timestamp.


-- 
Chuck Lever