Re: [PATCH 1/1] iio: proximity: cleanup fixes for vl53l1x-i2c

[Jonathan Cameron]

On Mon, 8 Jun 2026 18:15:17 +0600
Sirat <email@xxxxxxxx> wrote:

> On Mon, Jun 8, 2026 at 5:39 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> >
> > On Mon, Jun 08, 2026 at 09:32:06AM +0600, Siratul Islam wrote:  
> > > - Sort register defines list
> > > - Extract vl53l1x_wait_data_ready() polling logic
> > > - Logically split regmap_read_poll_timeout()  
> >
> > You may want to rephrase the commit message as in the current form it feels
> > like it has to be split to a few patches. In practice, it's basically one with
> > small amendments in the code that may or may not be split depending on the
> > Jonathan's preferences.
> >  
> I will rephrase the commit message to be simpler. It is very small
> change and I don't think it needs to be multiple commits.
> >
> > Also, you don't need a cover letter for a single patch. The cover letter makes
> > sense for the series and rarely for a single patch.
> >  
> I will remember that.
> >
> >  
> Thanks
> Sirat
Hi Sirat

I'd suggest slowing down. Generally, even for a small patch wait a few days
to allow for multiple reviews (and I'd have expressed my preference to
split this up saving us both a little time)

thanks,

Jonathan