Re: [PATCH] iio: pressure: bm1390: replace short msleeps with usleep_range

[Jonathan Cameron]

On Sun,  7 Jun 2026 14:00:18 +0000
Hungyu Lin <dennylin0707@xxxxxxxxx> wrote:

> Replace msleep(1) with usleep_range(1000, 2000) for the
> driver's short delays.
> 
> The BM1390 datasheet specifies a 1 ms reset cancel wait time
> (tSC1) during the power-on sequence. Use usleep_range() for
> these short delays, as it is more appropriate than msleep()
> and avoids unnecessarily long sleeps.

Hi Hungyu,

Use fsleep() which has the added advantage of standardizing the
'slack' so we don't have to thing about the values chosen

Thanks,

Jonathan

> 
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
> ---
>  drivers/iio/pressure/rohm-bm1390.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/pressure/rohm-bm1390.c b/drivers/iio/pressure/rohm-bm1390.c
> index 08146ca0f91d..35b9abc25a8a 100644
> --- a/drivers/iio/pressure/rohm-bm1390.c
> +++ b/drivers/iio/pressure/rohm-bm1390.c
> @@ -486,21 +486,21 @@ static int bm1390_chip_init(struct bm1390_data *data)
>  	if (ret)
>  		return ret;
>  
> -	msleep(1);
> +	usleep_range(1000, 2000);
>  
>  	ret = regmap_write_bits(data->regmap, BM1390_REG_RESET,
>  				BM1390_MASK_RESET, BM1390_RESET);
>  	if (ret)
>  		return ret;
>  
> -	msleep(1);
> +	usleep_range(1000, 2000);
>  
>  	ret = regmap_write_bits(data->regmap, BM1390_REG_RESET,
>  				BM1390_MASK_RESET, BM1390_RESET_RELEASE);
>  	if (ret)
>  		return ret;
>  
> -	msleep(1);
> +	usleep_range(1000, 2000);
>  
>  	ret = regmap_reinit_cache(data->regmap, &bm1390_regmap);
>  	if (ret) {
> @@ -575,7 +575,7 @@ static int bm1390_fifo_disable(struct iio_dev *idev)
>  	struct bm1390_data *data = iio_priv(idev);
>  	int ret;
>  
> -	msleep(1);
> +	usleep_range(1000, 2000);
>  
>  	guard(mutex)(&data->mutex);
>  	ret = bm1390_meas_set(data, BM1390_MEAS_MODE_STOP);