Re: [PATCH v2 1/2] dt-bindings: iio: ti,tmp117: add binding for the TMP119
From: Conor Dooley
Date: Mon Jun 08 2026 - 13:55:16 EST
On Mon, Jun 08, 2026 at 06:12:06PM +0100, Conor Dooley wrote:
> On Mon, Jun 08, 2026 at 06:00:24PM +0200, Romain Gantois wrote:
> > The TMP119 has the same register layout as the TMP117, and a better local
> > sensor accuracy. Add a compatible for it.
> >
> > Use ti,tmp117 as a fallback compatible for ti,tmp119.
> >
> > Signed-off-by: Romain Gantois <romain.gantois@xxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/iio/temperature/ti,tmp117.yaml | 16 +++++++++++-----
> > 1 file changed, 11 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> > index fbba5e934861c..d12dfef315b6c 100644
> > --- a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> > +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> > @@ -7,19 +7,25 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> > title: TI TMP117 - Digital temperature sensor with integrated NV memory
> >
> > description: |
> > - TI TMP116/117 - Digital temperature sensor with integrated NV memory that
> > - supports I2C interface.
> > + TI TMP116/117/119 - Digital temperature sensor with integrated NV memory
> > + that supports I2C interface.
> > https://www.ti.com/lit/gpn/tmp116
> > https://www.ti.com/lit/gpn/tmp117
> > + https://www.ti.com/lit/gpn/tmp119
> >
> > maintainers:
> > - Puranjay Mohan <puranjay12@xxxxxxxxx>
> >
> > properties:
> > compatible:
> > - enum:
> > - - ti,tmp116
> > - - ti,tmp117
> > + oneOf:
> > + - enum:
> > + - ti,tmp116
> > + - ti,tmp117
> > + - items:
> > + - enum:
> > + - ti,tmp119
> > + - const: ti,tmp117
>
> Indent here looks undersized, is that just the diff being weird?
It's not just the diff. Testing the binding would show you what's wrong.
pw-bot: changes-requested
>
> >
> > reg:
> > maxItems: 1
> >
> > --
> > 2.54.0
> >
Attachment:
signature.asc
Description: PGP signature