Re: [PATCH v5 0/6] s390: Enable Rust support and add required arch glue

[Jan Polensky]

On Mon, Jun 08, 2026 at 04:48:45PM +0100, Gary Guo wrote:
> On Mon Jun 8, 2026 at 3:36 PM BST, Alexander Gordeev wrote:
> > On Mon, Jun 08, 2026 at 04:21:22PM +0200, Heiko Carstens wrote:
> >> I guess Alexander will pick this up and route this via s390.
> >
> > Yes, I applied and scheduled it for -rc7.
> >
> > Two new files fall under the Rust maintainers scope:
> >
> >  rust/helpers/helpers.c | 1 +
> >  rust/helpers/string.c  | 8 ++++++++
> >
> > Please, let me know if someone is against it.
> > Otherwise, an ack would be ideal ;)
>
> Thes string.c is missing __rust_helper and it is also missing a trailing
> newline.
>
> Sashiko's report is accurate here:
> https://sashiko.dev/#/patchset/20260601174625.2910233-1-japo%40linux.ibm.com?part=4
>
> Best,
> Gary
>
> >
> > Thanks!
>
>
Hi Gary,

thanks for pointing this out.

I've added the missing __rust_helper. Regarding the trailing newline,
the file already ends with one locally:

  $ tail -c2 rust/helpers/string.c | hexdump -C
  00000000  7d 0a                                             |}.|

The other helpers are also mixed in this regard, so I kept it consistent.
If you prefer, I can send a v7 adjusting this as well.

Best regards,
Jan