Re: [PATCH v2] iio: imu: bmi323: remove unnecessary cast in watermark limit

[Nuno Sá]

On Mon, 2026-06-08 at 12:15 +0000, Hungyu Lin wrote:
> Remove the explicit u32 cast in the watermark limit calculation.
> 
> The BMI323_FIFO_FULL_IN_FRAMES macro can be used directly with
> min() without triggering type issues.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
> ---

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>

> Changes in v2:
> - Drop the unnecessary cast instead of using min_t().
> - Follow reviewer feedback from David Laight and Andy Shevchenko.
> 
>  drivers/iio/imu/bmi323/bmi323_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/bmi323/bmi323_core.c
> b/drivers/iio/imu/bmi323/bmi323_core.c
> index f3d499423399..72955a697a93 100644
> --- a/drivers/iio/imu/bmi323/bmi323_core.c
> +++ b/drivers/iio/imu/bmi323/bmi323_core.c
> @@ -1128,7 +1128,7 @@ static int bmi323_set_watermark(struct iio_dev *indio_dev,
> unsigned int val)
>  {
>  	struct bmi323_data *data = iio_priv(indio_dev);
>  
> -	val = min(val, (u32)BMI323_FIFO_FULL_IN_FRAMES);
> +	val = min(val, BMI323_FIFO_FULL_IN_FRAMES);
>  
>  	guard(mutex)(&data->mutex);
>  	data->watermark = val;