[PATCH 2/4] ata: pata_mpc52xx: remove redundant irq_dispose_mapping calls

From: Rosen Penev

Date: Mon Jun 08 2026 - 17:53:47 EST


bcom_ata_release() calls bcom_task_free(), which already calls
irq_dispose_mapping(tsk->irq). The explicit irq_dispose_mapping()
calls in the probe error path and remove function are redundant
and cause a double-free of the same mapping.

Remove them.

Assisted-by: opencode:big-pickle
Fixes: d01159dffa15 ("drivers/ata/pata_mpc52xx.c: clean up error handling code")
Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
---
drivers/ata/pata_mpc52xx.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
index 9af0aa89a5c6..1246b705a411 100644
--- a/drivers/ata/pata_mpc52xx.c
+++ b/drivers/ata/pata_mpc52xx.c
@@ -794,7 +794,6 @@ static int mpc52xx_ata_probe(struct platform_device *op)

err_free_irq:
free_irq(task_irq, priv);
- irq_dispose_mapping(task_irq);
err_free_task:
bcom_ata_release(dmatsk);
err1:
@@ -814,7 +813,6 @@ static void mpc52xx_ata_remove(struct platform_device *op)
/* Clean up DMA */
task_irq = bcom_get_task_irq(priv->dmatsk);
free_irq(task_irq, priv);
- irq_dispose_mapping(task_irq);
bcom_ata_release(priv->dmatsk);
irq_dispose_mapping(priv->ata_irq);
}
--
2.54.0