Re: [PATCH v2 2/6] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse

[Linus Walleij]

Hi Jun,

thanks for your patch!

On Mon, May 25, 2026 at 4:47 PM Jun Yan <jerrysteve1101@xxxxxxxxx> wrote:

> -       is31->shutdown_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_HIGH);
> +       /* Driving this GPIO line low (in fact high) takes the chip out of shutdown,
> +        * as it is flagged as GPIO_ACTIVE_LOW in provider (such as the device tree).
> +        */
> +       is31->shutdown_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_LOW);

This is fine but only if you also add a quirk to
drivers/gpio/gpiolib-of.c in of_gpio_try_fixup_polarity()
that will enforce the GPIOD_OUT_LOW property on the line.
Follow the examples.

This solves the API breakage.

It should probably be part of the same patch for bisectability.

Yours,
Linus Walleij