Re: [PATCH] filelock: update break_lease() stub with correct arguments

[Nathan Chancellor]

On Sun, Jun 07, 2026 at 06:46:11AM -0400, Jeff Layton wrote:
> When CONFIG_FILE_LOCKING=n, break_lease() becomes a no-op. The arguments
> for the function still need to change though.
> 
> Fixes: 4be9f3cc582a ("filelock: rework the __break_lease API to use flags")
> Reported-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202606071029.DKCs8WOs-lkp@xxxxxxxxx/
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>

Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
Tested-by: Nathan Chancellor <nathan@xxxxxxxxxx> # build

> ---
>  include/linux/filelock.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/filelock.h b/include/linux/filelock.h
> index 7a7a6e8a9a08..ec11cc6b4c58 100644
> --- a/include/linux/filelock.h
> +++ b/include/linux/filelock.h
> @@ -584,7 +584,7 @@ static inline bool is_delegated(struct delegated_inode *di)
>  	return false;
>  }
>  
> -static inline int break_lease(struct inode *inode, bool wait)
> +static inline int break_lease(struct inode *inode, unsigned int mode)
>  {
>  	return 0;
>  }
> 
> ---
> base-commit: 4d14e43b656c6ddefa91114975470a6a992b30ee
> change-id: 20260607-breakleasefix-3d5a9f1e1fd6
> 
> Best regards,
> -- 
> Jeff Layton <jlayton@xxxxxxxxxx>
> 

-- 
Cheers,
Nathan