Re: [PATCH] serial: 8250_pnp: Drop unused assignments from pnp_device_id arrays
From: Jiri Slaby
Date: Tue Jun 09 2026 - 00:34:46 EST
On 08. 06. 26, 19:00, Uwe Kleine-König (The Capable Hub) wrote:
Explicitly assigning .driver_data in drivers that don't use this member
is silly and a bit irritating. Drop these.
You do not do that in the patch though.
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
---
drivers/tty/serial/8250/8250_pnp.c | 308 ++++++++++++++---------------
1 file changed, 154 insertions(+), 154 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_pnp.c b/drivers/tty/serial/8250/8250_pnp.c
index 7a837fdf9df1..850709bb4a73 100644
--- a/drivers/tty/serial/8250/8250_pnp.c
+++ b/drivers/tty/serial/8250/8250_pnp.c
@@ -28,351 +28,351 @@
static const struct pnp_device_id pnp_dev_table[] = {
/* Archtek America Corp. */
/* Archtek SmartLink Modem 3334BT Plug & Play */
- { "AAC000F", 0 },
+ { .id = "AAC000F", .driver_data = 0 },
/* Anchor Datacomm BV */
...
--
js
suse labs