Re: [PATCH v2 3/3] arm64: dts: qcom: Add Eliza CQS EVK board

[Abel Vesa]

On 26-05-22 14:11:38, Konrad Dybcio wrote:
> On 5/19/26 6:09 PM, Abel Vesa wrote:
> > The Eliza CQS EVK board combines the CQ7790S-based (Eliza) SoM with the
> > common Eliza EVK base board, which provides connectors for different
> > peripherals.
> > 
> > Add a common Eliza EVK dtsi for the base board bits that can be reused
> > alongside other Eliza SoM variants. Then, add the final Eliza CQS EVK dts,
> > including the CQS SoM and common EVK dtsi.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile          |  1 +
> >  arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts | 20 ++++++++++++++++++++
> >  arch/arm64/boot/dts/qcom/eliza-evk.dtsi    | 20 ++++++++++++++++++++
> >  3 files changed, 41 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 795cee4757ab..e244e808a647 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -14,6 +14,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= apq8096sg-db820c.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)	+= eliza-cqs-evk.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= eliza-mtp.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= glymur-crd.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-evk.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts b/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts
> > new file mode 100644
> > index 000000000000..d1cf08ce19d1
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts
> > @@ -0,0 +1,20 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "eliza-cqs-som.dtsi"
> > +#include "eliza-evk.dtsi"
> > +
> > +/ {
> > +	model = "Qualcomm Technologies, Inc. Eliza CQS EVK";
> > +	compatible = "qcom,eliza-cqs-evk", "qcom,eliza-cqs-som", "qcom,eliza";
> > +};
> > +
> > +&tlmm {
> > +	gpio-reserved-ranges = <20 4>,   /* NFC SPI */
> > +			       <111 2>,  /* WCN UART1 */
> > +			       <118 1>;  /* NFC Secure I/O */
> 
> Are these going to be specific to the CQS-EVK?
> 

Sorry for the late reply.

These should probably belong in the SoM.

Will move them there and respin.

> Otherwise
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Thanks.