Re: [PATCH net] wifi: mac80211: fix memory leak in ieee80211_register_hw()

From: Dawei Feng

Date: Tue Jun 09 2026 - 03:48:59 EST


Hi Jeff,

Thanks for your time and the review.

On Mon, Jun 8, 2026 at 10:24 AM, Jeff Johnson wrote:
> > Fixes: 09b4a4faf9d0 ("mac80211: introduce capability flags for VHT EXT NSS support")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Zilin Guan <zilin@xxxxxxxxxx>
>
> why is this SOB here?
>
> > Signed-off-by: Dawei Feng <dawei.feng@xxxxxxxxxx>
>
> this is the posted author of the patch, and this patch hasn't been posted
> previously, so it is unclear why there is an additional S-o-b

Zilin is the discoverer of this bug. We are in the same research group,
and he actively participated in reviewing this patch.

To better align with the kernel submission guidelines, I will add a
"Co-developed-by:" tag in the v2 patch for Zilin to properly reflect his
contributions. Would this be acceptable?

> I'm wondering if it would be more logical to have another label at the same
> place, i.e. fail_band, since it is illogical to goto fail_wiphy_register when
> you aren't performing the wiphy_register function

Thanks for the suggestion. I will add a new label fail_band and send out
the v2 patch soon.

Thanks,
Dawei