Re: [PATCH net v3 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered

[Parthiban.Veerasooran]

Hi Selvamani,

On 08/06/26 10:14 am, Selvamani Rajagopal wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> Subject: Re: [PATCH net v3 2/2] dt-bindings: net: updated interrupt type to be active low,
>> level triggered
>>
>>
>> This Message Is From an External Sender
>> This message came from outside your organization.
>>
>> On 04/06/26 10:30 pm, Andrew Lunn wrote:
>>>
>>> That is the problem with edge interrupts when level should be
>>> used. They work %99.9 of the time, so many developers don't notice
>>> they have it wrong. And then one day it all stops because an interrupt
>>> got lost.
>> I agree with this point. But simply changing the interrupt type in the
>> existing logic is not sufficient. Level‑triggered interrupts require
>> careful handling in the driver, and with the current implementation I am
>> observing issues under system load when using level‑triggered IRQs, as
>> also discussed in another thread.
> 
> 
> Parthiban,
> 
> I agree. When we change to level triggered interrupt, current mechanism won't work as
> we are not disabling the interrupt when we handle them.
> 
> I have a modification ready that uses threaded IRQ mechanism, which disables further interrupt until the
> thread returns.(with level trigger changes of course).  My simple tests (ping and ptp4l) work fine with those
> changes I am going to run some heavy traffic tests.  If I find them stable, I will post them in my next v3 submission.
Thank you for the update. I have also implemented threaded IRQ handling, 
and it works fine on my side as well. Since you are already planning to 
post patches for this implementation and have mentioned that you will 
include them in your next submission, I will hold off on posting my 
patch for now. Please let me know if you would like me to share it from 
my side.

Best regards,
Parthiban V
> 
>>
>> Best regards,
>> Parthiban V
>>>
>>> Andrew
>