Re: [PATCH v3 18/21] pinctrl: starfive: Add StarFive JHB100 per2pok controller driver

[Changhuang Liang]

Hi, Bartosz

Thanks for the review.

> On Wed, 3 Jun 2026 07:53:44 +0200, Changhuang Liang
> <changhuang.liang@xxxxxxxxxxxxxxxx> said:
> > Add pinctrl driver for StarFive JHB100 SoC Peripheral-2 Power OK
> > (per2pok) pinctrl controller.
> >
> > Co-developed-by: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/pinctrl/starfive/Kconfig              | 12 +++
> >  drivers/pinctrl/starfive/Makefile             |  1 +
> >  .../pinctrl-starfive-jhb100-per2pok.c         | 97
> +++++++++++++++++++
> >  3 files changed, 110 insertions(+)
> >  create mode 100644
> > drivers/pinctrl/starfive/pinctrl-starfive-jhb100-per2pok.c
> >
> > diff --git a/drivers/pinctrl/starfive/Kconfig
> > b/drivers/pinctrl/starfive/Kconfig
> > index edc3b6d9c8d7..bf5915e0a5f2 100644
> > --- a/drivers/pinctrl/starfive/Kconfig
> > +++ b/drivers/pinctrl/starfive/Kconfig
> > @@ -91,6 +91,18 @@ config PINCTRL_STARFIVE_JHB100_PER2
> >  	  peripherals supporting inputs, outputs, configuring pull-up/pull-down
> >  	  and interrupts on input changes.
> >
> > +config PINCTRL_STARFIVE_JHB100_PER2POK
> > +	tristate "StarFive JHB100 SoC Peripheral-2 Power OK pinctrl and GPIO
> driver"
> > +	depends on ARCH_STARFIVE || COMPILE_TEST
> > +	depends on OF
> 
> I don't see any real dependency on CONFIG_OF here, am I missing something?
> The OF ID matching is available even with !CONFIG_OF.

I will move it under config PINCTRL_STARFIVE_JHB100.

> 
> Same elsewhere.
> 
> Bart

Best Regards,
Changhuang