Re: [PATCH] exfat: add swap_activate support

[Namjae Jeon]

On Tue, Jun 9, 2026 at 12:32 AM Jan Polensky <japo@xxxxxxxxxxxxx> wrote:
>
> On Wed, Jun 03, 2026 at 11:34:55PM +0900, Namjae Jeon wrote:
> > On Wed, Jun 3, 2026 at 10:20 PM Jan Polensky <japo@xxxxxxxxxxxxx> wrote:
> > >
> > > Commit 614f71ca1bdf ("exfat: add iomap buffered I/O support")
> > > converted exfat buffered I/O to iomap, but did not add a
> > > .swap_activate handler to the address_space_operations.
> > >
> > > swapon(2) on an exfat swapfile then fails with EINVAL, which causes
> > > LTP swap tests to fail.
> > >
> > > Add exfat_iomap_swap_activate() and hook it into exfat_aops so exfat
> > > uses iomap_swapfile_activate() for swapfile activation.
> > >
> > > Fixes: 614f71ca1bdf ("exfat: add iomap buffered I/O support")
> > > Closes: https://lore.kernel.org/all/20260603110212.3020276-1-japo@xxxxxxxxxxxxx/
> > > Signed-off-by: Jan Polensky <japo@xxxxxxxxxxxxx>
> > Applied it to #dev.
> > Thanks!
>
> Hi Namjae,
>
> I think one line might have been missed when applying my patch:
>
>     .swap_activate = exfat_iomap_swap_activate,
>
> I checked linux-next (master and next-20260604 / next-20260605),
> and the issue is still present there.
>
> Link:
> https://lore.kernel.org/all/20260603131950.321858-1-japo@xxxxxxxxxxxxx/
>
> Could you please take a look?
Sorry about that, my bad. Your patch wasn't being applied properly, so
I tried to update it manually and made a mistake. Anyway, I have just
fixed it. Thank you very much for pointing it out!