Re: [PATCH net-next v2 1/2] ipv6: mcast: annotate data-races around mca_flags
From: Yuyang Huang
Date: Tue Jun 09 2026 - 06:47:22 EST
On Tue, Jun 9, 2026 at 6:36 PM Eric Dumazet <edumazet@xxxxxxxxxx> wrote:
>
> On Tue, Jun 9, 2026 at 1:11 AM Yuyang Huang <sigefriedhyy@xxxxxxxxx> wrote:
> >
> > /proc/net/igmp6 walks IPv6 multicast memberships under RCU and
> > prints mca_flags without holding idev->mc_lock. The multicast paths
> > update the field while holding idev->mc_lock.
> >
> > Annotate this intentional lockless snapshot with READ_ONCE() and the
> > matching writers with WRITE_ONCE().
> >
> > Signed-off-by: Yuyang Huang <sigefriedhyy@xxxxxxxxx>
> > ---
>
> You forgot to carry Ido's tag? Have you changed something in this
> patch compared to V1?
Sorry, I forgot to carry over Ido's Reviewed-by tag for patch 1. I
didn't touch patch 1, as shown in the cover letter, I only touched
patch 2 to fix the bug pointed out by Sashiko.
Shall I resent the V2 patch sets to add back the tag?