Re: [PATCH v5 3/3] hwmon:(pmbus/xdp720) Fix driver issues xdp720/730

[Guenter Roeck]

On Tue, Jun 09, 2026 at 12:52:31PM +0530, ASHISH YADAV wrote:
> From: Ashish Yadav <ashish.yadav@xxxxxxxxxxxx>
> 
> Fix driver issues:
> - Adds the missing regulator and property files in include
> - Declares XDP720_DEFAULT_RIMON as unsigned constant
> - Declares struct pmbus_driver_info xdp720_info as constant
> 
> Signed-off-by: Ashish Yadav <ashish.yadav@xxxxxxxxxxxx>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/xdp720.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/pmbus/xdp720.c b/drivers/hwmon/pmbus/xdp720.c
> index 0f106c13e7ca..b273e53a01f3 100644
> --- a/drivers/hwmon/pmbus/xdp720.c
> +++ b/drivers/hwmon/pmbus/xdp720.c
> @@ -17,13 +17,15 @@
>  #include <linux/of_device.h>
>  #include <linux/bitops.h>
>  #include <linux/math64.h>
> +#include <linux/property.h>
> +#include <linux/regulator/consumer.h>
>  #include "pmbus.h"
>  
>  /*
>   * The IMON resistor required to generate the system overcurrent protection.
>   * Arbitrary default Rimon value: 2k Ohm
>   */
> -#define XDP720_DEFAULT_RIMON 2000000000 /* 2k ohm */
> +#define XDP720_DEFAULT_RIMON 2000000000U /* 2k ohm */
>  #define XDP720_TELEMETRY_AVG 0xE9
>  #define XDP720_TELEMETRY_AVG_GIMON BIT(10) /* high/low GIMON select */
>  
> @@ -38,7 +40,7 @@ struct xdp720_data {
>  	struct pmbus_driver_info info;
>  };
>  
> -static struct pmbus_driver_info xdp720_info = {
> +static const struct pmbus_driver_info xdp720_info = {
>  	.pages = 1,
>  	.format[PSC_VOLTAGE_IN] = direct,
>  	.format[PSC_VOLTAGE_OUT] = direct,