Re: [PATCH 2/3] powercap: qcom: Add SPEL powercap driver

[Manaf Meethalavalappu Pallikunhi]

Hi Konrad,


On 5/21/2026 4:47 PM, Konrad Dybcio wrote:
> On 5/19/26 12:49 PM, Manaf Meethalavalappu Pallikunhi wrote:
> > The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware
> > based power monitoring and limiting capabilities for various power
> > domains including System, SoC, CPU clusters, GPU, and various other
> > subsystems.
> >
> > The driver integrates with the Linux powercap framework, exposing SPEL
> > capabilities through powercap sysfs interfaces.
> >
> > Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> > ---
>
> [...]
>
> > +/* Constraint configuration */
> > +static struct spel_constraint_info constraints[] = {
> > +	/* SYS domain constraints */
> > +	{ 0x10, 0x70, BIT(0), SPEL_DOMAIN_SYS, POWER_LIMIT1 },
> > +	{ 0x14, 0x74, BIT(1), SPEL_DOMAIN_SYS, POWER_LIMIT2 },
> > +	{ 0x18, 0x78, BIT(2), SPEL_DOMAIN_SYS, POWER_LIMIT3 },
> > +	{ 0x1C, 0x7C, BIT(3), SPEL_DOMAIN_SYS, POWER_LIMIT4 },
> > +	/* SOC domain constraints */
> > +	{ 0x00, 0x60, BIT(4), SPEL_DOMAIN_SOC, POWER_LIMIT1 },
> > +	{ 0x04, 0x64, BIT(5), SPEL_DOMAIN_SOC, POWER_LIMIT2 },
> > +	{ 0x08, 0x68, BIT(6), SPEL_DOMAIN_SOC, POWER_LIMIT3 },
> > +	{ 0x0C, 0x6C, BIT(7), SPEL_DOMAIN_SOC, POWER_LIMIT4 },
>
> Lowercase hex, please
>
> Can this data be const?

ACK

Thanks,
Manaf

> Konrad