Re: [PATCH v2] soc: samsung: exynos-pmu: fix of_node refcount leak in exynos_get_pmu_regmap()

[Krzysztof Kozlowski]

On 09/06/2026 15:33, Weigang He wrote:
>  drivers/soc/samsung/exynos-pmu.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c
> index d58376c38179b..265a095316079 100644
> --- a/drivers/soc/samsung/exynos-pmu.c
> +++ b/drivers/soc/samsung/exynos-pmu.c
> @@ -167,11 +167,13 @@ static const struct mfd_cell exynos_pmu_devs[] = {
>   */
>  struct regmap *exynos_get_pmu_regmap(void)
>  {
> -	struct device_node *np = of_find_matching_node(NULL,
> -						      exynos_pmu_of_device_ids);
> -	if (np)
> -		return exynos_get_pmu_regmap_by_phandle(np, NULL);
> -	return ERR_PTR(-ENODEV);
> +	struct device_node *np __free(device_node) =
> +		of_find_matching_node(NULL, exynos_pmu_of_device_ids);
> +
> +	if (!np)
> +		return ERR_PTR(-ENODEV);
> +
> +	return exynos_get_pmu_regmap_by_phandle(np, NULL);

I don't understand why do you need to change the rest of the function.

Best regards,
Krzysztof