Re: [PATCH 7/8] dt-bindings: input: microchip,cap11xx: Add CAP1114 support
From: Conor Dooley
Date: Tue Jun 09 2026 - 10:43:50 EST
On Tue, Jun 09, 2026 at 10:08:27PM +0800, Jun Yan wrote:
> > On Sat, Jun 06, 2026 at 11:04:00PM +0800, Jun Yan wrote:
> > > CAP1114 is a 14-channel capacitive touch sensor with 11 LED outputs
> > > and hardware reset support.
> > >=20
> > > Add the compatible string for CAP1114, include its datasheet URL,
> > > and update the maximum count of LED channels and linux,keycodes entries.
> > >=20
> > > Add description for microchip,input-threshold: CAP1114 only provides eight
> > > threshold entries, which does not match its total channel count.
> > >=20
> > > Signed-off-by: Jun Yan <jerrysteve1101@xxxxxxxxx>
> > > ---
> > > .../bindings/input/microchip,cap11xx.yaml | 21 +++++++++++++++++--
> > > 1 file changed, 19 insertions(+), 2 deletions(-)
> > >=20
> > > diff --git a/Documentation/devicetree/bindings/input/microchip,cap11xx.ya=
> > ml b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> > > index e307628350c2..08233386a433 100644
> > > --- a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> > > +++ b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> > > @@ -12,6 +12,7 @@ description: |
> > > =20
> > > For more product information please see the links below:
> > > CAP1106: https://ww1.microchip.com/downloads/en/DeviceDoc/00001624B.=
> > > + CAP1114: https://ww1.microchip.com/downloads/en/DeviceDoc/00002444A.=
> > > CAP1126: https://ww1.microchip.com/downloads/en/DeviceDoc/00001623B.=
> > > CAP1188: https://ww1.microchip.com/downloads/en/DeviceDoc/00001620C.=
> > > CAP1203: https://ww1.microchip.com/downloads/en/DeviceDoc/00001572B.=
> > > @@ -26,6 +27,7 @@ properties:
> > > compatible:
> > > enum:
> > > - microchip,cap1106
> > > + - microchip,cap1114
> > > - microchip,cap1126
> > > - microchip,cap1188
> > > - microchip,cap1203
> > > @@ -62,7 +64,7 @@ properties:
> > > =20
> > > linux,keycodes:
> > > minItems: 3
> > > - maxItems: 8
> > > + maxItems: 14
> > > description: |
> > > Specifies an array of numeric keycode values to
> > > be used for the channels. If this property is
> > > @@ -122,6 +124,8 @@ properties:
> > > is required for a touch to be registered, making the touch sensor =
> > less
> > > sensitive.
> > > The number of entries must correspond to the number of channels.
> > > + CAP1114 is an exception where channels 8~14 reuse the eighth entry=
> > 's
> > > + threshold, so counts differ.
> > > =20
> > > microchip,calib-sensitivity:
> > > $ref: /schemas/types.yaml#/definitions/uint32-array
> > > @@ -149,7 +153,7 @@ patternProperties:
> > > reg:
> > > description: LED channel number
> > > minimum: 0
> > > - maximum: 7
> > > + maximum: 10
> > > =20
> > > required:
> > > - reg
> > > @@ -199,6 +203,19 @@ allOf:
> > > reg:
> > > maximum: 1
> > > =20
> > > + - if:
> > > + properties:
> > > + compatible:
> > > + contains:
> > > + enum:
> > > + - microchip,cap1188
> >
> > I don't understand this restriction, shouldn't this be
> > if: properties: compatible: not: contains: microchip,cap1114
> > so that the constraints before your change are retained?
> >
>
> Previously, the LED reg property had a default maximum of 7 for CAP1188.
> With the addition of CAP1114, the default maximum is now 11.
> An if-then constraint is added to limit the LED count for CAP1188.
Ah, is this because cap1188 is the only existing device in the binding
that actually has LEDs?
Attachment:
signature.asc
Description: PGP signature