Re: [PATCH v3] iio: magnetometer: bmc150: use FIELD_PREP and FIELD_GET helpers

[Andy Shevchenko]

On Tue, Jun 09, 2026 at 02:01:16AM +0000, Hungyu Lin wrote:
> Replace open-coded bitfield operations with FIELD_PREP() and
> FIELD_GET() helpers where appropriate.
> 
> Also simplify bmc150_magn_set_odr() by returning directly from
> the matching table entry.

...

> v3:
>  - Add missing include <linux/bitfield.h>

You need to slow down. The comment I gave from the previous round still
applies. Now even more, id est the location of new header is chosen in
suboptimal way. Always try to keep as much as possible headers sorted.

-- 
With Best Regards,
Andy Shevchenko