Re: [PATCH] nouveau/firmware: fix memory leak on BL load failure

[Timur Tabi]

On Tue, 2026-06-09 at 16:57 +0800, Dawei Feng wrote:
>         if (bl) {
>                 const struct firmware *blob_bl;
> 
>                 ret = nvkm_firmware_load_name(subdev, bl, "", ver, &blob_bl);
>                 if (ret)
>                         goto done;
> 
>                 ...
>                 nvkm_firmware_put(blob_bl);
>                 if (!fw->boot)
>                         ret = -ENOMEM;
>         } else {
>                 fw->boot_addr = fw->nmem_base;
>         }
> 
> done:
>         if (ret)
>                 nvkm_falcon_fw_dtor(fw);
> 
>         nvkm_firmware_put(blob);
>         return ret;

Yes, this is good.  Thanks.