Re: [PATCH v3] iio: magnetometer: bmc150: use FIELD_PREP and FIELD_GET helpers
From: Andy Shevchenko
Date: Tue Jun 09 2026 - 11:34:32 EST
On Tue, Jun 09, 2026 at 08:12:30AM -0700, Hungyu Lin wrote:
> > You need to slow down. The comment I gave from the previous round still
> > applies. Now even more, id est the location of new header is chosen in
> > suboptimal way. Always try to keep as much as possible headers sorted.
>
> Thanks for the review.
>
> I'll remove the blank line.
>
> Could you suggest the preferred placement
> for <linux/bitfield.h> in this include list?
As I said, create an additional (prerequisite) patch that sorts them first.
--
With Best Regards,
Andy Shevchenko