Re: [PATCH net-next] drivers/net/ethernet/qualcomm/emac: Use strscpy() to copy the ethtool strings

From: Timur Tabi

Date: Tue Jun 09 2026 - 11:37:06 EST


> diff --git a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> index f502db9cdea9..ffc300641aac 100644
> --- a/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> +++ b/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
> @@ -95,7 +95,7 @@ static void emac_get_strings(struct net_device *netdev, u32 stringset, u8 *data)
>
> switch (stringset) {
> case ETH_SS_PRIV_FLAGS:
> - strcpy(data, "single-pause-mode");
> + strscpy(data, "single-pause-mode", ETH_GSTRING_LEN);
> break;

Acked-by: Timur Tabi <timur@xxxxxxxxxx>