Re: [PATCH 03/15] x86/virt/tdx: Make TDX Module initialize Extensions

[Adrian Hunter]

On 22/05/2026 06:41, Xu Yilun wrote:
> +/* Initialize the TDX Module Extensions then Extension-SEAMCALLs can be used */

Reads slightly better without "the", so taking Tony's suggestion
one word less:

"Initialize TDX Module Extensions for Extension-SEAMCALLs"

> +static int tdx_ext_init(void)
> +{
> +	struct tdx_module_args args = {};
> +	u64 r;
> +
> +	do {
> +		r = seamcall(TDH_EXT_INIT, &args);
> +	} while (r == TDX_INTERRUPTED_RESUMABLE);
> +
> +	if (r != TDX_SUCCESS)

There seems to be TDX_PREV_FEATURES_ENABLED which is unused,
but could it turn up here?

> +		return -EFAULT;
> +
> +	return 0;
> +}
Otherwise:

Reviewed-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>