[PATCH] net: hsr: simplify fill_last_seq_nrs()

From: Yury Norov

Date: Tue Jun 09 2026 - 13:28:13 EST


The function checks the HSR_PT_SLAVE_A and HSR_PT_SLAVE_B bitmaps
for emptiness right before calling find_last_bit().

This pass may be avoided, because if the bitmap is empty, the
find_last_bit() returns >= HSR_SEQ_BLOCK_SIZE

Signed-off-by: Yury Norov <ynorov@xxxxxxxxxx>
---
net/hsr/hsr_framereg.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c
index 124619920d38..bf143b86999b 100644
--- a/net/hsr/hsr_framereg.c
+++ b/net/hsr/hsr_framereg.c
@@ -827,18 +827,14 @@ static void fill_last_seq_nrs(struct hsr_node *node, u16 *if1_seq, u16 *if2_seq)
block_sz = hsr_seq_block_size(node);
block = node->block_buf + block_off * block_sz;

- if (!bitmap_empty(block->seq_nrs[HSR_PT_SLAVE_B - 1],
- HSR_SEQ_BLOCK_SIZE)) {
- seq_bit = find_last_bit(block->seq_nrs[HSR_PT_SLAVE_B - 1],
- HSR_SEQ_BLOCK_SIZE);
+ seq_bit = find_last_bit(block->seq_nrs[HSR_PT_SLAVE_B - 1], HSR_SEQ_BLOCK_SIZE);
+ if (seq_bit < HSR_SEQ_BLOCK_SIZE)
*if1_seq = (block->block_idx << HSR_SEQ_BLOCK_SHIFT) | seq_bit;
- }
- if (!bitmap_empty(block->seq_nrs[HSR_PT_SLAVE_A - 1],
- HSR_SEQ_BLOCK_SIZE)) {
- seq_bit = find_last_bit(block->seq_nrs[HSR_PT_SLAVE_A - 1],
- HSR_SEQ_BLOCK_SIZE);
+
+ seq_bit = find_last_bit(block->seq_nrs[HSR_PT_SLAVE_A - 1], HSR_SEQ_BLOCK_SIZE);
+ if (seq_bit < HSR_SEQ_BLOCK_SIZE)
*if2_seq = (block->block_idx << HSR_SEQ_BLOCK_SHIFT) | seq_bit;
- }
+
spin_unlock_bh(&node->seq_out_lock);
}

--
2.53.0