Re: [PATCH net-next v2 03/14] net: pcs: pcs-xpcs-regmap: support XPCS memory-mapped MDIO bus via regmap

[Alex Elder]

On 6/5/26 10:35 AM, Maxime Chevallier wrote:
> > +					  const struct xpcs_regmap_config *config)
> > +{
> > +	static atomic_t id = ATOMIC_INIT(-1);
> > +	struct dw_xpcs_regmap *pxpcs;
> > +	struct dw_xpcs *xpcs;
> > +	int ret;
> > +
> > +	pxpcs = devm_kzalloc(dev, sizeof(*pxpcs), GFP_KERNEL);
> > +	if (!pxpcs)
> > +		return ERR_PTR(-ENOMEM);
> > +
> > +	pxpcs->dev = dev;
> > +	pxpcs->regmap = config->regmap;
> > +	pxpcs->reg_indir = config->reg_indir;
> Looking at the overall series, is there any reason for this flag ?
>
> Looks like the reg_indir=false path isn't used at all in this series.
>
> Maybe just drop it and let anyone add it back should the need arise ?

You're right that it's always true (in this one case it's used).

I think it's fine to get rid of the reg_indir flag, and that
will simplify a lot of things.  It eliminates the need for the
xpcs_regmap_config structure (just register with regmap pointer
instead).

The "pcs-xpcs-regmap.h" header could be removed too if we declared
devm_xpcs_regmap_register() in "drivers/net/pcs/pcs-xpcs.h".  (I
won't do this unless you or someone else suggests it though.)

I will rearrange the code to support only the indirect access
method for this code.

					-Alex