Re: [PATCH v3 09/23] dmaengine: sdxi: Start functions on probe, stop on remove

[Tycho Andersen]

On Fri, Jun 05, 2026 at 07:02:12PM -0500, Nathan Lynch via B4 Relay wrote:
> +static void sdxi_pci_remove(struct pci_dev *pdev)
> +{
> +	pci_disable_sriov(pdev);

I think this should be in patch 3, since that is what introduces
.sriov_configure(), and then this patch adds the additional call to
sdxi_unregister().

Thanks,

Tycho

> +	sdxi_unregister(&pdev->dev);
> +}
> +
>  static const struct pci_device_id sdxi_id_table[] = {
>  	{ PCI_DEVICE_CLASS(PCI_CLASS_ACCELERATOR_SDXI, 0xffffff) },
>  	{ }
> @@ -73,6 +79,7 @@ static struct pci_driver sdxi_driver = {
>  	.name = "sdxi",
>  	.id_table = sdxi_id_table,
>  	.probe = sdxi_pci_probe,
> +	.remove = sdxi_pci_remove,
>  	.sriov_configure = pci_sriov_configure_simple,
>  };