Re: [PATCH v2 0/2] xfs: fix inode leak and clean up attr intent recovery

[Yingjie Gao]

在 2026/6/10 14:30, Carlos Maiolino 写道:
> On Wed, Jun 10, 2026 at 10:20:26AM +0800, Yingjie Gao wrote:
>> Hi all,
>>
>> The first patch fixes a leaked inode reference in
>> xfs_attr_recover_work() when transaction allocation fails after the
>> recovered attr work item has been attached to the defer pending list.
>>
>> The second patch cleans up the same function's exit paths so they follow
>> the same linear cleanup style as the neighboring bmap and exchmaps
>> recovery helpers, and initializes the local error variable in the same
>> style.
>>
>> Changes since v1:
>> - route the transaction allocation failure through out_rele in patch 1,
>>   as Darrick suggested;
>> - keep patch 2 focused on the remaining cleanup-path reshaping and the
>>   local error initialization.
> 
> Please avoid sending new versions in-reply-to the previous version. Send
> them as a new thread.
> 
Understood, sorry about that.  I will make sure new versions are sent
as separate threads going forward.

Thanks,
Yingjie
```
>>
>> Thanks,
>> Yingjie
>>
>> Yingjie Gao (2):
>>   xfs: fix inode ref leak in attr intent recovery
>>   xfs: clean up attr intent recovery error paths
>>
>>  fs/xfs/xfs_attr_item.c | 17 ++++++++++++-----
>>  1 file changed, 12 insertions(+), 5 deletions(-)
>>
>> -- 
>> 2.20.1
>>
>