Re: [PATCH] ext4: fix circular lock dependency in ext4_ext_migrate

[Zhou, Yun]

On 6/9/26 20:05, Jan Kara wrote:
> Looks good. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> Just one nit below:
>
> > @@ -591,9 +592,10 @@ int ext4_ext_migrate(struct inode *inode)
> >        ext4_journal_stop(handle);
> >   out_tmp_inode:
> >        unlock_new_inode(tmp_inode);
> > -     iput(tmp_inode);
> >   out_unlock:
> >        ext4_writepages_up_write(inode->i_sb, alloc_ctx);
> > +     if (tmp_inode)
> > +             iput(tmp_inode);
> iput(NULL) is properly handled so you don't need the if (tmp_inode) check
> here.
Hi Jan,

Thank you for your careful review. Should I remove this redundant check 
in v2?

BR,
Yun