Re: [PATCH v1] pinctrl: qcom: lpass-lpi: drop unused runtime-PM write helper

From: Krzysztof Kozlowski

Date: Wed Jun 10 2026 - 05:07:13 EST


On 10/06/2026 10:57, Ajay Kumar Nandam wrote:
>> So why do we need __lpi_gpio_write()?
>
> Hi Krzysztof,
>
> Thanks, good point.
>
> I will respin with:
> Reported-by: Nathan Chancellor <nathan@xxxxxxxxxx>


And checkpatch.

>
> About __lpi_gpio_write(): it is still needed for the in-callers path
> where runtime PM is already held and we only need the raw MMIO helper.
> The unused wrapper is lpi_gpio_write(), so this fix removes only that
> dead function.

No. Why did you have to add __ prefix? Why do we need function named
with such style?

Best regards,
Krzysztof