Re: [PATCH v4] rust: make `build_assert` module the home of related macros
From: Gary Guo
Date: Wed Jun 10 2026 - 06:02:52 EST
On Wed Jun 10, 2026 at 8:29 AM BST, Miguel Ojeda wrote:
> On Tue, 09 Jun 2026 19:19:42 +0100 Gary Guo <gary@xxxxxxxxxxx> wrote:
>>
>> I think I just kept it as is when rebasing. It's file to have them grouped in
>> the crate to.
>
> Thanks for confirming!
>
>> This one is using size_of, align_of, c_void which are all in prelude. However it
>> looks like I forgot to actually remove these imports in the last version, and I
>> didn't change it during rebase.
>
> Ah, I see, makes sense.
>
>> Are you okay with fixing during applying, or do you want me to send a new version?
>
> I did it on my side. I also tweaked a couple more bits: they were already
> `no_inline`, and I noted that they sadly do not appear in the prelude anymore,
> but the change looks fine and that may be more of a `rustdoc`-side issue or
> design choice.
I think if the re-export is of form "use crate::build_assert::*" then it will
still be the same semantics but would be appearing now?
Best,
Gary