Re: [PATCH v7 1/2] dt-bindings: pwm: dwc: Add eswin compatible and resets property

[Krzysztof Kozlowski]

On 10/06/2026 11:25, Xuyang Dong wrote:
>>> Hi Krzysztof,
>>>
>>> Thanks for your comments and time.
>>>
>>> Regarding snps,dw-apb-timers-pwm2, we previously intended to add the 
>>> resets property in the same patch. 
>>> However, as you suggested, we will split it into a separate patch.
>>
>> I find commit msg still confusing. Please always clearly explain WHY you
>> are doing changes.
>>
> 
> Hi Krzysztof,
> 
> Thanks for your comments.
> 
> According to the DesignWare IP for PWM controllers manual, it seems to me 
> that Ben's previous submission may have missed the optional resets property.
> 
> Therefore, I would like to confirm: should I submit a separate fix patch for
> the resets property, or include it as a feature patch in this series?
> 

One change is adding resets to existing binding for existing device.
With its own rationale.

Another change is adding new device compatible with its own necessary
changes (if resets are different).

Best regards,
Krzysztof