Re: [PATCH 1/2] iio: magnetometer: bmc150: sort includes
From: Andy Shevchenko
Date: Wed Jun 10 2026 - 06:58:51 EST
On Wed, Jun 10, 2026 at 04:24:17AM +0000, Hungyu Lin wrote:
> Sort the include list alphabetically.
...
> -#include <linux/module.h>
> -#include <linux/i2c.h>
> -#include <linux/interrupt.h>
> #include <linux/cleanup.h>
> #include <linux/delay.h>
> -#include <linux/slab.h>
> -#include <linux/pm.h>
> -#include <linux/pm_runtime.h>
> -#include <linux/iio/iio.h>
> -#include <linux/iio/sysfs.h>
> +#include <linux/i2c.h>
> #include <linux/iio/buffer.h>
> #include <linux/iio/events.h>
> +#include <linux/iio/iio.h>
> +#include <linux/iio/sysfs.h>
> #include <linux/iio/trigger.h>
> #include <linux/iio/trigger_consumer.h>
> #include <linux/iio/triggered_buffer.h>
Oh, I didn't noticed this one is mixed with the other linux/*.h.
> +#include <linux/interrupt.h>
> +#include <linux/module.h>
> +#include <linux/pm.h>
> +#include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> +#include <linux/slab.h>
Please, make it in two groups
linux/*.h
...blank line...
linux/iio/*.h
...blank line...
"...internal header..."
--
With Best Regards,
Andy Shevchenko