Re: [PATCH 1/5] arm64: dts: qcom: msm8998-sony-yoshino: Drop extra bias-disable
From: Krzysztof Kozlowski
Date: Wed Jun 10 2026 - 08:07:39 EST
On 10/06/2026 13:43, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> The msm8998-common i2c5 pin sleep state is defined with a pull-up. The
> Sony Yoshino DTSI attempts to override that to bias-disable without
> removing the existing bias-pull-up. Remove the override and use the
> common definition to resolve a dt checker warning.
Maybe the bias-pull-up should be simply removed? At least you should
document here why you chosen that way to fix the warning.
>
> The change itself shouldn't have any functional effect, maybe except
> a miniscule increase in power usage. The defaults may need revisiting
> at a later date either way.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
Best regards,
Krzysztof