Re: [PATCH 3/3] media: renesas: vsp1: Make reset control optional to support platforms without a reset line

[Laurent Pinchart]

Hi Prabhakar,

Thank you for the patch.

On Thu, Apr 30, 2026 at 11:09:29AM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> 
> Switch the VSP1 driver to use devm_reset_control_get_optional_shared()
> when requesting its reset control. Some newer Renesas SoCs integrating
> VSP1 such as RZ/T2H do not provide a reset line for the VSP IP block.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

> ---
>  drivers/media/platform/renesas/vsp1/vsp1_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drv.c b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> index 627b5046fa80..605fac57bd93 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> @@ -947,7 +947,7 @@ static int vsp1_probe(struct platform_device *pdev)
>  	if (irq < 0)
>  		return irq;
>  
> -	vsp1->rstc = devm_reset_control_get_shared(&pdev->dev, NULL);
> +	vsp1->rstc = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
>  	if (IS_ERR(vsp1->rstc))
>  		return dev_err_probe(&pdev->dev, PTR_ERR(vsp1->rstc),
>  				     "failed to get reset control\n");

-- 
Regards,

Laurent Pinchart