Re: [PATCH] HID: pidff: Use correct effect type in effect update
From: Jiri Kosina
Date: Wed Jun 10 2026 - 12:34:26 EST
On Tue, 9 Jun 2026, Oleg Makarenko wrote:
> When updating an existing effect, the effect type from the last created
> effect was sent to the device instead of the updated one.
> This caused incorrect reports when a game creates multiple different
> effects and updates only one that is not the last created.
>
> Fixes FFB in multiple games that create multiple simultaneous effects
> (Forza Horizon 5/6).
>
> Fixes: 224ee88fe395 ("Input: add force feedback driver for PID devices")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Tested-by: Oliver Roundtree <oroundtree1@xxxxxxxxx>
> Co-developed-by: Ryno Kotzé <lemon.xah@xxxxxxxxx>
> Signed-off-by: Ryno Kotzé <lemon.xah@xxxxxxxxx>
> Signed-off-by: Oleg Makarenko <oleg@xxxxxxxxxxxx>
Applied, thanks.
--
Jiri Kosina
SUSE Labs