Re: [PATCH v1] scsi: Improve style of pnp_device_id array terminator
From: Bart Van Assche
Date: Wed Jun 10 2026 - 12:43:03 EST
On 6/10/26 7:36 AM, Uwe Kleine-König (The Capable Hub) wrote:
diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
index fd766282d4a4..93dab19c1cb9 100644
--- a/drivers/scsi/aha1542.c
+++ b/drivers/scsi/aha1542.c
@@ -1083,7 +1083,7 @@ static int isa_registered;
#ifdef CONFIG_PNP
static const struct pnp_device_id aha1542_pnp_ids[] = {
{ .id = "ADP1542" },
- { .id = "" }
+ { }
};
MODULE_DEVICE_TABLE(pnp, aha1542_pnp_ids);
diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
index 270eae7ac427..41731a7304dd 100644
--- a/drivers/scsi/g_NCR5380.c
+++ b/drivers/scsi/g_NCR5380.c
@@ -739,7 +739,7 @@ static struct isa_driver generic_NCR5380_isa_driver = {
#ifdef CONFIG_PNP
static const struct pnp_device_id generic_NCR5380_pnp_ids[] = {
{ .id = "DTC436e", .driver_data = BOARD_DTC3181E },
- { .id = "" }
+ { }
};
MODULE_DEVICE_TABLE(pnp, generic_NCR5380_pnp_ids);
Although in general I'm not a fan of code cleanups for legacy drivers, I
like this change. Hence:
Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>