Re: [PATCH 2/3] media: rzg2l-cru: Remove unused kerneldoc description
From: Jacopo Mondi
Date: Wed Jun 10 2026 - 12:49:37 EST
Hi Ricardo
On Wed, Jun 10, 2026 at 04:20:07PM +0000, Ricardo Ribalda wrote:
> The variable has been previously removed but not its kerneldoc.
>
> Also remove the leftover reference to state in the description of qlock.
>
> This patch fixes the following warning:
>
> Warning: drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h:164
> Excess struct member 'state' description in 'rzg2l_cru_dev'
upsie
indeed!
>
> Fixes: 85d8820d4869 ("media: rzg2l-cru: Remove the 'state' variable")
My only question is if this qualifies for stable or not...
Honestly, I would drop the Fixes tag here
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> index 5bf334e173d2..b426bc7898bf 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> @@ -116,11 +116,9 @@ struct rzg2l_cru_info {
> * @scratch_phys: physical address of the scratch buffer
> *
> * @qlock: protects @queue_buf, @buf_list, @sequence
> - * @state
> * @queue_buf: Keeps track of buffers given to HW slot
> * @buf_list: list of queued buffers
> * @sequence: V4L2 buffers sequence number
> - * @state: keeps track of operation state
> *
> * @format: active V4L2 pixel format
> */
>
> --
> 2.54.0.1099.g489fc7bff1-goog
>