Re: [PATCH next v2] drivers/of/overlay: Use memcpy() to copy known length strings
From: Rob Herring (Arm)
Date: Wed Jun 10 2026 - 14:48:54 EST
On Mon, 08 Jun 2026 19:51:21 +0100, David Laight wrote:
> Avoid calls to strcpy().
> The lengths of the strings have been used for the kzalloc(), replace
> the strcpy() calls with memcpy() using the known lengths.
>
> Signed-off-by: David Laight <david.laight.linux@xxxxxxxxx>
> ---
>
> v2: Improve commit message
>
> This is one of a group of patches that remove potentially unbounded
> strcpy() calls.
>
> They are mostly replaced by strscpy() or, when strlen() has just been
> called, with memcpy() (usually including the '\0').
>
> Calls with copy string literals into arrays are left unchanged.
> They are safe and easily detected as such.
>
> The changes were made by getting the compiler to detect the calls and
> then fixing the code by hand.
>
> Note that all the changes are only compile tested.
>
> Some Makefiles were changed to allow files to contain strcpy().
> As well as 'difficult to fix' files, this included 'show' functions
> as they really need to use sysfs_emit() or seq_printf().
>
> All the patches are being sent individually to avoid very long cc lists.
> Apologies for the terse commit messages and likely unexpected tags.
> (There are about 100 patches in total.)
>
> drivers/of/overlay.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks!