Re: [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log

[Paul Menzel]

Dear Xiuzhuo,


Thank you for the patch, which was applied today.

Am 10.06.26 um 08:42 schrieb Xiuzhuo Shang:
> Firmware version is critical for bug triage. Users reporting issues
> typically share dmesg output rather than debugfs contents, requiring
> extra communication rounds to collect this information. Log the FW
> build version directly to the kernel log so it is immediately
> available in bug reports.
>
> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@xxxxxxxxxxxxxxxx>
> ---
> Example output:
>    Bluetooth: hci0: QCA FW build version: BTFW.MOSELLE.1.1.3-00106-MSL_PATCHZ-1

Please put it in the commit message next time.

Also, just for completeness, could you please paste all the 
Bluetooth/hci0/QCA logs, so that maybe a more condensed logging format 
can be found?

>   drivers/bluetooth/btqca.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index dda76365726f..04ebe290bc78 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -143,6 +143,8 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
>   
>   	hci_set_fw_info(hdev, "%s", build_label);
>   
> +	bt_dev_info(hdev, "QCA FW build version: %s", build_label);
> +
>   	kfree(build_label);
>   out:
>   	kfree_skb(skb);


Kind regards,

Paul