Re: [PATCH] gpu: nova-core: don't declare booter firmware for FSP chipsets

[John Hubbard]

On 6/8/26 5:00 PM, Timur Tabi wrote:
> On Tue, 2026-06-09 at 00:57 +0200, Danilo Krummrich wrote:
>>> +        // FSP-based chipsets (Hopper and later) boot the GSP via the FMC image
>>> +        // loaded by FSP. Older chipsets use the SEC2 booter instead.
>>
>> NIT: This is slightly ambiguous, since despite technically being the same
>> generation, by architecture ID Ada numerically sits in between Hopper and
>> Blackwell, but does not use FSP.
> 
> Maybe we should add a comment to the define_chipset! block in gpu.rs which clarifies that even
> though GH100 has a lower chipid then AD102, we consider Hopper to be a newer architecture than Ada.

Yes. I'll send a tiny follow-up patch for these points.

thanks,
-- 
John Hubbard