Re: [PATCH v2 0/2] dmaengine: dw-axi-dmac: clean up DMAC enable and PM
From: Vinod Koul
Date: Thu Jun 11 2026 - 01:52:02 EST
On Mon, 25 May 2026 00:10:20 -0700, tze.yee.ng@xxxxxxxxxx wrote:
> The DesignWare AXI DMAC driver enables the controller in axi_dma_resume(),
> which is invoked from the runtime PM resume path and from probe. Calling
> axi_dma_enable() again at the start of every block transfer is redundant
> on the normal path.
>
> That extra call had also masked a gap in system-sleep power management:
> with only runtime PM callbacks registered, a channel could remain allocated
> across suspend/resume while the runtime usage count stayed non-zero and
> axi_dma_runtime_resume() was not run, leaving DMAC_CFG and clocks out of
> sync with software state. Removing the per-transfer enable without fixing
> PM would make that scenario more visible.
>
> [...]
Applied, thanks!
[1/2] dmaengine: dw-axi-dmac: drop redundant DMAC enable in block start
commit: dc6d681e1571c89cd38145926fb2513d70a633e1
[2/2] dmaengine: dw-axi-dmac: fix PM for system sleep and channel alloc
commit: df0c2dc68770cf43f15df40b184df030b850ea05
Best regards,
--
~Vinod