Re: [PATCH v13 2/4] crypto: spacc - Add SPAcc ahash support

[Herbert Xu]

On Thu, Jun 04, 2026 at 10:22:08PM +0530, Pavitrakumar Managutte wrote:
> Add ahash support to SPAcc driver.
> Below are the hash algos supported:
> - cmac(aes)
> - xcbc(aes)
> - cmac(sm4)
> - xcbc(sm4)
> - hmac(md5)
> - md5
> - hmac(sha1)
> - sha1
> - sha224
> - sha256
> - sha384
> - sha512
> - hmac(sha224)
> - hmac(sha256)
> - hmac(sha384)
> - hmac(sha512)
> - sha3-224
> - sha3-256
> - sha3-384
> - sha3-512
> - michael_mic
> 
> Co-developed-by: Bhoomika Kadabi <bhoomikak@xxxxxxxxxxxxxxx>
> Signed-off-by: Bhoomika Kadabi <bhoomikak@xxxxxxxxxxxxxxx>
> Acked-by: Ross Bannerman <rbannerm@xxxxxxxxxxxx>
> Signed-off-by: Pavitrakumar Managutte <pavitrakumarm@xxxxxxxxxxxxxxx>
> Signed-off-by: Manjunath Hadli <manjunath.hadli@xxxxxxxxxxxxxxx>
> ---
>  drivers/crypto/dwc-spacc/spacc_ahash.c     |  897 ++++++++++++++
>  drivers/crypto/dwc-spacc/spacc_core.c      | 1311 ++++++++++++++++++++
>  drivers/crypto/dwc-spacc/spacc_core.h      |  838 +++++++++++++
>  drivers/crypto/dwc-spacc/spacc_device.c    |  275 ++++
>  drivers/crypto/dwc-spacc/spacc_device.h    |  237 ++++
>  drivers/crypto/dwc-spacc/spacc_hal.c       |  374 ++++++
>  drivers/crypto/dwc-spacc/spacc_hal.h       |  114 ++
>  drivers/crypto/dwc-spacc/spacc_interrupt.c |  329 +++++
>  drivers/crypto/dwc-spacc/spacc_manager.c   |  611 +++++++++
>  9 files changed, 4986 insertions(+)
>  create mode 100644 drivers/crypto/dwc-spacc/spacc_ahash.c
>  create mode 100644 drivers/crypto/dwc-spacc/spacc_core.c
>  create mode 100644 drivers/crypto/dwc-spacc/spacc_core.h
>  create mode 100644 drivers/crypto/dwc-spacc/spacc_device.c
>  create mode 100644 drivers/crypto/dwc-spacc/spacc_device.h
>  create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.c
>  create mode 100644 drivers/crypto/dwc-spacc/spacc_hal.h
>  create mode 100644 drivers/crypto/dwc-spacc/spacc_interrupt.c
>  create mode 100644 drivers/crypto/dwc-spacc/spacc_manager.c

Please also check the Sashiko comments, some of those look alarming:

https://sashiko.dev/#/patchset/20260604165210.1141842-1-pavitrakumarm%40vayavyalabs.com

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt