Re: [PATCH net-next v2] ixgbe: implement get_queue_stats_rx

[Kshitiz Bartariya]

Hi Simon,

I was thinking of making these changes in a separate patch, as it could make a single patch big.
I'll do the changes as suggested and will v3.

Thanks,
Kshitiz


From: Simon Horman <horms@xxxxxxxxxx>
To: "Kshitiz Bartariya"<kshitiz.bartariya@xxxxxxxxxxx>
Cc: <anthony.l.nguyen@xxxxxxxxx>, <przemyslaw.kitszel@xxxxxxxxx>, <andrew+netdev@xxxxxxx>, <davem@xxxxxxxxxxxxx>, <edumazet@xxxxxxxxxx>, <kuba@xxxxxxxxxx>, <pabeni@xxxxxxxxxx>, <aleksandr.loktionov@xxxxxxxxx>, <jacob.e.keller@xxxxxxxxx>, <jedrzej.jagielski@xxxxxxxxx>, <piotr.kwapulinski@xxxxxxxxx>, <intel-wired-lan@xxxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
Date: Tue, 09 Jun 2026 00:17:33 +0530
Subject: Re: [PATCH net-next v2] ixgbe: implement get_queue_stats_rx

 > On Wed, Jun 03, 2026 at 11:18:51PM +0530, Kshitiz Bartariya wrote:
 > > Hook into the netdev_stat_ops interface to expose per RX queue
 > > statistics through the netdev generic netlink API.
 > > 
 > > The following counters are filled:
 > > 
 > >  - alloc_fail: sum of alloc_rx_page_failed and alloc_rx_buff_failed
 > > 
 > >  - csum_bad: maps directly to csum_err, which is incremented for both
 > >    IP header and L4 checksum errors in ixgbe_rx_checksum().
 > > 
 > > The new per-queue stats can be observed with:
 > >   $ ynltool qstats show scope queue
 > > 
 > > Signed-off-by: Kshitiz Bartariya <kshitiz.bartariya@xxxxxxxxxxx>
 > > ---
 > > v2:
 > >  Amended commit message with command to get RX queue stats as 
 > > suggested by Jedrzej Jagielski.
 > > 
 > > v1: https://lore.kernel.org/lkml/20260602100932.21838-1-kshitiz.bartariya@xxxxxxxxxxx/
 > > 
 > > 
 > >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++++++++++++++++
 > >  1 file changed, 16 insertions(+)
 > 
 > Hi Kshitiz,
 > 
 > There is AI-generated review of this patch-set available on both
 > https://sashiko.dev and https://netdev-ai.bots.linux.dev/sashiko/
 > I would appreciate it if you could look over that.
 >