Re: [PATCH 1/2] pinctrl: tigerlake: add some pin groups and functions for INTC1055

[GaryWang]

On Thu, 11 Jun 2026 at 15:40, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Thu, Jun 11, 2026 at 03:17:04PM +0800, GaryWang wrote:
> > On Wed, 10 Jun 2026 at 22:37, Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxx> wrote:
> > > On Wed, Jun 10, 2026 at 04:24:09PM +0200, Mika Westerberg wrote:
> > > > On Wed, Jun 10, 2026 at 04:34:23PM +0800, GaryWang wrote:
> > > > > Add i2c0, i2c1, pwm0, uart1, ssp2 pin groups & functions in tgllp_soc_data
> > > > >  for device id INTC1055.
> > > >
> > > > Okay we can see that from the code but why? Can you explain it here too?
> > >
> > > Yeah, good point. I know the why? because I reviewed the pinctrl-upboard
> > > driver, but unprepared reader doesn't know all the details.
> > >
> > To answering Mika's question,
> > Upboard hat pins using SOC's native function pins, and pinctrl-upboard can
> > map them to the correct functions through gpio-aggregator.
> > Thomas was involved in the implementation of the SOC pinctrl-upboard
> > in Apollolake,
> > and he is very familiar with the details.
>
> You need to make it to be the part of the commit message explaining this
> clearly ("somebody who knows somebody" way of explanation is not an option).
>
got it, will detail explaining in next version.

> --
> With Best Regards,
> Andy Shevchenko
>
>