Re: [Intel-wired-lan] [PATCH net] ice: fix memory leak in ice_lbtest_prepare_rings()

[Marcin Szycik]

On 11.06.2026 04:02, Dawei Feng wrote:
> Hi Marcin,
> 
> Thanks for your review.
> 
> On Tue, 9 Jun 2026 at 16:27:20 Marcin Szycik wrote:
>> IMO last two paragraphs should not be included in commit message,
>> rather after ---.
> 
> The reason the manual inspection and testing commentary was placed above
> the `---` line is that we were strictly following the example template
> provided in Documentation/process/researcher-guidelines.rst. 
> 
> In the researcher-guidelines[1], the example explicitly places the build
> and hardware testing disclaimer before the Signed-off-by tags, which is
> why we included it directly in the commit message.
> 
> Please let me know if you would like a v2 to adjust the position of the
> mentioned commit log details.

Thanks for linking the docs, now I see the commit message is exactly as
recommended.

Thanks,
Marcin
>> Correct me if I'm wrong, but looks like unroll order is reversed:
>> ice_vsi_stop_lan_tx_rings() unrolls ice_vsi_cfg_lan()
>> ice_vsi_free_rx_rings() unrolls ice_vsi_setup_rx_rings()
>> (was reversed before this patch too, but since we're fixing it, might as well)
> 
> You are right. I'll update it in v2.
> 
> [1] https://docs.kernel.org/process/researcher-guidelines.html
> 
> Best regards,
> Dawei