Re: [PATCH 0/2] fuse: fix CUSE device node leak and add regression test
From: Miklos Szeredi
Date: Thu Jun 11 2026 - 06:29:51 EST
On Wed, 8 Apr 2026 at 17:23, Alberto Ruiz via B4 Relay
<devnull+aruiz.redhat.com@xxxxxxxxxx> wrote:
> Patch 2 adds a kselftest that reproduces the bug by forcing cdev_alloc()
> to fail after device_add() has succeeded, then verifying that no /dev
> node is leaked. To trigger the failure deterministically, a
> CONFIG_FAULT_INJECTION-guarded module parameter (cuse_inject_cdev_failure)
> is added to cuse.c. The test falls back to failslab with stack-trace
> filtering when the parameter is unavailable.
>
> I'm on the fence about the fault injection parameter in patch 2 -- it's
> only a few lines and it's guarded behind CONFIG_FAULT_INJECTION, but I
> understand if it feels too intrusive for production code. Happy to drop
> the kselftest or rework the injection approach if the maintainers prefer.
> The fix in patch 1 stands on its own regardless.
I don't think it's worth adding this to upstream, though I'm impressed
by the thoroughness of your work.
I'll reference this patchset from commit header so the information is retained.
Thanks,
Miklos